Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added support for automatically setting of domain #12

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

jarl-dk commented Nov 8, 2012

Setting domain automatically based on Rack request environment.

jarl-dk commented Nov 9, 2012

I must admit I am a bit new to Google Analytics...

Is this Pull Request pointless? Is the google analytics behaviour provided with this:

    config.middleware.use Rack::GoogleAnalytics,{
      :tracker => 'UA-12345-1',
      :async => true,
      :multiple => true,
    }

exactly the same as this:

    config.middleware.use Rack::GoogleAnalytics,{
      :tracker => 'UA-12345-1',
      :async => true,
    }

I ask, because if so, the pull request seem pointless

Owner

kangguru commented Aug 9, 2013

As the default behavior of setDomainName is auto which will try to obtain the current host from _setDomainName this will be pretty much the same. Only thing is that you'll have to also set the domain config if you use the multiple option.

jarl-dk commented Aug 12, 2013

So your point is when not having multiple domains, the default behaviour is automatic domain detection and setting. Setting the domain option is only necessary when :multiple => true.

If so, maybe some description of this in the README would help.

Owner

kangguru commented Aug 12, 2013

Thats how i get it :) I've added a bit to the README

@kangguru kangguru closed this Dec 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment