Fix BptreeMap range iter adjacent leaves #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstyear
approved these changes
Jun 26, 2024
|
Thank you! I'm so sorry you had so many problems with the iterators :( |
|
No problem, glad it fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #118.
Description for the edge case is in the comment.
I haven't found a way to check if one leaf is ahead of another.
So i took an advantage of the fact that we are advancing leaf iterators one at a time.
I.e. before advancing right/left leaf iterator we check if they are pointing to the same node and if so there is no elements left.