Trim trailing '-' sign (#955)

* trim trailing '-' sign

* additional test

* Update tags.go

Here's what I recommend.

* trimming

* trimming after replacement test

Co-authored-by: Aaron Alpar <55999015+aaron-kasten@users.noreply.github.com>

pkg/blockstorage/tags/tags.go

@@ -88,6 +88,7 @@ func SanitizeValueForGCP(value string) string {
 	}
 	sanitizedVal = strings.ToLower(sanitizedVal)
 	sanitizedVal = re.ReplaceAllString(sanitizedVal, "_")
+	sanitizedVal = strings.TrimRight(sanitizedVal, "_-")
 	return sanitizedVal
 }
 

pkg/blockstorage/tags/tags_test.go

@@ -0,0 +1,56 @@
+package tags
+
+import (
+	"testing"
+
+	. "gopkg.in/check.v1"
+)
+
+func Test(t *testing.T) { TestingT(t) }
+
+type TagsSuite struct{}
+
+var _ = Suite(&TagsSuite{})
+
+func (s *TagsSuite) TestSanitizeValueForGCP(c *C) {
+	for _, tc := range []struct {
+		input  string
+		output string
+	}{
+		{
+			input:  "abcd",
+			output: "abcd",
+		},
+		{
+			input:  "kasten__snapshot-wordpress-on-rbd-ceph-ns-2021-04-15t18-11-27z-abcd",
+			output: "kasten__snapshot-wordpress-on-rbd-ceph-ns-2021-04-15t18-11-27z",
+		},
+		{
+			input:  "kasten__snapshot-wordpress-on-rbd-ceph-ns-",
+			output: "kasten__snapshot-wordpress-on-rbd-ceph-ns",
+		},
+		{
+			input:  "kasten__snapshot-wordpress-on-rbd-ceph-ns---",
+			output: "kasten__snapshot-wordpress-on-rbd-ceph-ns",
+		},
+		{
+			input:  "kasten__snapshot-wordpress! ?*()",
+			output: "kasten__snapshot-wordpress",
+		},
+		{
+			input:  "kasten__snapshot-wordpress-on-rbd-ceph-ns-__",
+			output: "kasten__snapshot-wordpress-on-rbd-ceph-ns",
+		},
+		{
+			input:  "kasten__snapshot-wordpress-on-rbd-ceph-ns__--",
+			output: "kasten__snapshot-wordpress-on-rbd-ceph-ns",
+		},
+		{
+			input:  "ALLCAPS",
+			output: "allcaps",
+		},
+	} {
+		out := SanitizeValueForGCP(tc.input)
+		c.Assert(out, Equals, tc.output)
+	}
+}