Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more linters to golangci.yaml #2173

Closed
kale-amruta opened this issue Jul 13, 2023 · 1 comment · Fixed by #2239, #2238, #2505, #2500 or #2240
Closed

Add more linters to golangci.yaml #2173

kale-amruta opened this issue Jul 13, 2023 · 1 comment · Fixed by #2239, #2238, #2505, #2500 or #2240
Assignees
@ankitjain235
Labels
enhancement
Projects
Kanister

Comments

@kale-amruta
Copy link
Contributor

kale-amruta commented Jul 13, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently .golangci.yaml has only following linters enabled:
- gofmt
- whitespace
- gocognit
- unparam

We should consider adding few more linters that would have enable developers to have better coding standards as well as speed up development and code reviews

Describe the solution you'd like
Following linters could be enabled in the golangci
@infraq infraq added this to To Be Triaged in Kanister Jul 13, 2023
@kale-amruta kale-amruta changed the title Enhance golangci.yaml to add more go-lint checks Add more linters to golangci.yaml Jul 13, 2023
@ankitjain235
Copy link
Contributor

ankitjain235 commented Aug 7, 2023 •
edited
Loading

  1. lll, nakedret, asciicheck, depguard, dogsled, dupl, exportloopref: Enable lll, nakedret, asciicheck, depguard, dogsled, dupl, exportloopref golang linters #2238
    NOTE: depguard was enabled in this PR but had to be disabled temporarily until v1.53.x invisibly breaks configs that were valid in v1.52.x if they used depguard golangci/golangci-lint#3906 is fixed and a new release is available with the fix.

  2. importas: Enable importas golang linter #2239

  3. misspell, nestif: Enable misspell, nestif golang linter #2240

  4. gci, goprintffuncname, nolintlint: Enable gci, goprintffuncname, nolintlint linters #2500

  5. stylecheck: Enable stylecheck linter #2505

@github-actions github-actions bot added the stale label Nov 6, 2023
This was linked to pull requests Dec 21, 2023
Enable importas golang linter #2239
Merged
Enable lll, nakedret, asciicheck, depguard, dogsled, dupl, exportloopref golang linters #2238
Merged
Enable stylecheck linter #2505
Merged
Enable gocritic and gocyclo linters #2236
Merged
@ankitjain235 ankitjain235 removed a link to a pull request Dec 21, 2023
Enable gocritic and gocyclo linters #2236
Merged
10 tasks
@ankitjain235 ankitjain235 mentioned this issue Dec 21, 2023
Open
@ankitjain235 ankitjain235 moved this from To Be Triaged to Review Required in Kanister Dec 21, 2023
This was linked to pull requests Dec 21, 2023
Enable gci, goprintffuncname, nolintlint linters #2500
Merged
Enable misspell, nestif golang linter #2240
Merged
@mergify mergify bot closed this as completed in #2240 Dec 21, 2023
Kanister automation moved this from Review Required to Done Dec 21, 2023
@ankitjain235 ankitjain235 moved this from Done to Review Required in Kanister Dec 21, 2023
@kanisterio kanisterio deleted a comment from github-actions bot May 18, 2024
@kanisterio kanisterio deleted a comment from github-actions bot May 18, 2024
@julio-lopez julio-lopez mentioned this issue May 30, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ankitjain235 ankitjain235

Labels
enhancement
Projects
Kanister
Review Required
Milestone
No milestone
3 participants
@pavannd1 @ankitjain235 @kale-amruta