Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable lll, nakedret, asciicheck, depguard, dogsled, dupl, exportloopref golang linters #2238

Merged
merged 22 commits into from Dec 20, 2023
Merged

Enable lll, nakedret, asciicheck, depguard, dogsled, dupl, exportloopref golang linters #2238

merged 22 commits into from Dec 20, 2023

Conversation

ankitjain235
Copy link
Contributor

@ankitjain235 ankitjain235 commented Aug 3, 2023 •
edited

Change Overview

This PR enables following Golang linters:

  • lll
  • nakedret
  • asciicheck
  • depguard
  • dogsled
  • dupl
  • exportloopref

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 3, 2023
@ankitjain235 ankitjain235 changed the title Add lll linter Enable go linter - PR#2 Aug 3, 2023
@ankitjain235 ankitjain235 marked this pull request as ready for review August 3, 2023 15:29
@ankitjain235 ankitjain235 mentioned this pull request Aug 7, 2023
Closed
@ankitjain235 ankitjain235 changed the title Enable go linter - PR#2 Enable lll, nakedret, asciicheck, depguard, dogsled, dupl, exportloopref golang linters Dec 1, 2023
Base automatically changed from enable-linters-1 to master December 4, 2023 05:57
PrasadG193
PrasadG193 reviewed Dec 4, 2023
View reviewed changes
.golangci.yml Show resolved Hide resolved
pkg/app/cockroachdb.go Outdated Show resolved Hide resolved
r4rajat
r4rajat reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@r4rajat r4rajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavannd1 pavannd1 removed the request for review from viveksinghggits December 4, 2023 19:26
PrasadG193
PrasadG193 reviewed Dec 6, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left minor suggestions and a question. Otherwise looks good

pkg/app/cockroachdb.go Show resolved Hide resolved
pkg/function/scale_workload.go Outdated Show resolved Hide resolved
pkg/function/scale_workload.go Outdated Show resolved Hide resolved
@ankitjain235 ankitjain235 mentioned this pull request Dec 8, 2023
Merged
10 tasks
PrasadG193
PrasadG193 approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kanister automation moved this from In Progress to Reviewer approved Dec 19, 2023
@mergify mergify bot merged commit f3e91ee into master Dec 20, 2023
14 checks passed
Kanister automation moved this from Reviewer approved to Done Dec 20, 2023
@mergify mergify bot deleted the enable-linters-2 branch December 20, 2023 09:19
@ankitjain235 ankitjain235 linked an issue Dec 21, 2023 that may be closed by this pull request
Add more linters to golangci.yaml #2173
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r4rajat r4rajat r4rajat left review comments

@PrasadG193 PrasadG193 PrasadG193 approved these changes

@pavannd1 pavannd1 Awaiting requested review from pavannd1

@hairyhum hairyhum Awaiting requested review from hairyhum

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more linters to golangci.yaml
3 participants
@ankitjain235 @PrasadG193 @r4rajat