Improve error message for undefined template key #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akankshakumari393
changed the title
pavannd1
reviewed
Jun 24, 2021
Co-authored-by: Vivek Singh <vsingh.ggits.2010@gmail.com>
pavannd1
approved these changes
Jul 2, 2021
Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
Improve error message while rendering undefined template key. Currently, we get an error message
" map has no entry for key "Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan
Error message when
'{{ .ArtifactsIn.cloudObject.KeyValue.paths }}'is being rendered andpathsis undefined.time="2021-06-28T06:42:27.261951017Z" level=info msg="Failed to execute phase: v1alpha1.Phase{Name:\"pullFromBlobStore\", State:\"pending\", Output:map[string]interface {}(nil)}:" ActionSet=restore-backup-ggzfj-xbmgf File=pkg/controller/controller.go Function="github.com/kanisterio/kanister/pkg/controller.(*Controller).runAction.func1" Line=438 Phase=pullFromBlobStore cluster_name=6fe9c799-279c-4f46-bfda-c6e470080eaa error="Can't render template: key <paths> Not found" hostname=myrelease-kanister-operator-68ff8c8d54-tgp7v