Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetClusterScopedResources to App interface #1033

Merged
merged 4 commits into from
Jun 24, 2021
Merged

Add GetClusterScopedResources to App interface #1033

merged 4 commits into from
Jun 24, 2021

Conversation

akankshakumari393
Copy link
Contributor

@akankshakumari393 akankshakumari393 commented Jun 22, 2021

Change Overview

This PR defines a function in App Interface GetClusterScopedResources()

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • πŸ› Bugfix
  • 🌻 Feature
  • πŸ—ΊοΈ Documentation
  • πŸ€– Test

Issues

  • #XXX

Test Plan

  • πŸ’ͺ Manual
  • ⚑ Unit test
  • πŸ’š E2E

Copy link
Contributor

@PrasadG193 PrasadG193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor suggestions on comments. Otherwise looks good.

pkg/app/app.go Outdated Show resolved Hide resolved
pkg/app/kafka.go Show resolved Hide resolved
pkg/app/kafka.go Show resolved Hide resolved
pkg/app/kafka.go Show resolved Hide resolved
Co-authored-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@mergify mergify bot merged commit f33c70c into master Jun 24, 2021
@mergify mergify bot deleted the K10-7404 branch June 24, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants