-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add info back into configuration #1466
Conversation
Thanks for submitting this pull request 🎉. The team will review it soon and get back to you. If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document. |
Are the downstream callers being changed to use the config values from the map? |
@pavannd1 Downstream callers will store these information alongside with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit, will approve
Co-authored-by: Sirish Bathina <sirish@kasten.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Change Overview
Add non-mandatory Azure information back into config structure. The purpose of such change, is to bring back information regarding Azure config such as
AZURE_RESOURCE_MANAGER_ENDPOINT
,AZURE_AD_ENDPOINT
,AZURE_AD_RESOURCE
, andAZURE_CLOUD_ENV_ID
to callers and eventually end-users.The end goal is to have all Azure config information will be available to end-user.
Pull request type
Please check the type of change your PR introduces:
Test Plan
Manual test was ran downstream to ensure informations are being passed back
Was run as a sanity check. No unit test added nor changed since there was no functional change