Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nil pointer panic VMWare blockstorage #1584

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Fix nil pointer panic VMWare blockstorage #1584

merged 1 commit into from
Aug 5, 2022

Conversation

denisvmedia
Copy link
Contributor

Change Overview

This PR fixes nil pointer panic in VMWare blockstorage implementation when getting a snapshot had failed.

Pull request type

Please check the type of change your PR introduces:

  • 馃悰 Bugfix

@github-actions
Copy link

github-actions bot commented Aug 4, 2022

Thanks for submitting this pull request 馃帀. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Aug 4, 2022
@denisvmedia
Copy link
Contributor Author

This is a panic example that this PR addresses.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x30f68e1]

goroutine 21791 [running]:
github.com/kanisterio/kanister/pkg/blockstorage/vmware.(*FcdProvider).SnapshotCreate(0xc002b98300, {0x4b58f80, 0xc00288f600}, {{0x0, 0x0}, {0x16694e00, 0xed9022a27, 0x0}, 0x0, {0xc001d6bfb0, ...}, ...}, ...)
        /root/go/pkg/mod/github.com/kanisterio/kanister@v0.0.0-20220730000319-6e8b88145c81/pkg/blockstorage/vmware/vmware.go:297 +0x581

Kanister automation moved this from In Progress to Reviewer approved Aug 5, 2022
@mergify mergify bot merged commit 0e7ded2 into master Aug 5, 2022
Kanister automation moved this from Reviewer approved to Done Aug 5, 2022
@mergify mergify bot deleted the fix-nil-pointer-crash branch August 5, 2022 07:19
r4rajat pushed a commit to r4rajat/kanister that referenced this pull request Aug 28, 2022
@denisvmedia @r4rajat
Fix nil pointer panic VMWare blockstorage (kanisterio#1584)
c71e345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchistikov pchistikov pchistikov approved these changes

@carlbraganza carlbraganza Awaiting requested review from carlbraganza

@ihcsim ihcsim Awaiting requested review from ihcsim

@pavannd1 pavannd1 Awaiting requested review from pavannd1

Assignees
No one assigned
Labels
kueue
Projects
Kanister
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@denisvmedia @pchistikov