Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mocking snapshotter interface #918

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Mocking snapshotter interface #918

merged 2 commits into from
Mar 8, 2021

Conversation

bathina2
Copy link
Contributor

@bathina2 bathina2 commented Mar 4, 2021

Change Overview

Generating mocks for the snapshotter interface for use externally.

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • πŸ› Bugfix
  • 🌻 Feature
  • πŸ—ΊοΈ Documentation
  • πŸ€– Test

Issues

  • #XXX

Test Plan

  • πŸ’ͺ Manual
  • ⚑ Unit test
  • πŸ’š E2E

Copy link
Contributor

@pavannd1 pavannd1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @PrasadG193 take a look once!

@bathina2 bathina2 added the kueue label Mar 5, 2021
Merge branch 'master' of https://github.com/kanisterio/kanister into mock_provider_interface
@mergify mergify bot merged commit 57ccf78 into master Mar 8, 2021
@mergify mergify bot deleted the mock_provider_interface branch March 8, 2021 23:14
chaitanya-baraskar pushed a commit to chaitanya-baraskar/kanister that referenced this pull request Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants