Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new PodOption to override default container name #935

Merged
merged 2 commits into from
Mar 22, 2021
Merged

Add a new PodOption to override default container name #935

merged 2 commits into from
Mar 22, 2021

Conversation

PrasadG193
Copy link
Contributor

@PrasadG193 PrasadG193 commented Mar 19, 2021 •
edited

Change Overview

Add a new PodOption to override default container name

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E
$ go test -v -check.f="PodSuite" .
=== RUN   Test
found pod
OK: 4 passed
--- PASS: Test (41.18s)
PASS
ok      github.com/kanisterio/kanister/pkg/kube 41.188s

@PrasadG193
New PodOption to override container name
d70763f 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@PrasadG193
Add unit test for containerName option
dd601f2 
Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
@mergify mergify bot merged commit 65ebd2d into master Mar 22, 2021
@mergify mergify bot deleted the override-containername branch March 22, 2021 03:28
@onkarbhat
Copy link
Contributor

LGTM

PrasadG193 added a commit that referenced this pull request Apr 1, 2021
@PrasadG193
Add a new PodOption to override default container name (#935)
69b5eb2 
* New PodOption to override container name

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

* Add unit test for containerName option

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
PrasadG193 added a commit that referenced this pull request Apr 5, 2021
@PrasadG193
Add a new PodOption to override default container name (#935)
7c51be9 
* New PodOption to override container name

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

* Add unit test for containerName option

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
chaitanya-baraskar pushed a commit to chaitanya-baraskar/kanister that referenced this pull request Apr 5, 2021
@PrasadG193 @chaitanya-baraskar
Add a new PodOption to override default container name (kanisterio#935)
1295c93 
* New PodOption to override container name

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>

* Add unit test for containerName option

Signed-off-by: Prasad Ghangal <prasad.ghangal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavannd1 pavannd1 pavannd1 approved these changes

@onkarbhat onkarbhat Awaiting requested review from onkarbhat

Assignees
No one assigned
Labels
kueue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PrasadG193 @onkarbhat @pavannd1