added stage to debug gorelease failure #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrasadG193
reviewed
Mar 30, 2021
Comment on lines
-130
to
-131
| archives: | ||
| - allow_different_binary_count: true |
There was a problem hiding this comment.
Why this change is required @A-kanksh-a ?
There was a problem hiding this comment.
I had added this as a part of #840, as I was getting different binary counts issue on the local machine while adding kafka-adobe-s3-connector related image to goreleaser.
After adding the command make release-snapshot with field allow_different_binary_count set to true caused issue.
And also, Kanister CI environment is not having different binary counts issue for kafka-adobe-s3-connector related image, so that flag is not needed.
akankshakumari393
force-pushed
the
build-tool-image
branch
from
06dc563
to
bb809d6
Compare
pavannd1
approved these changes
Apr 2, 2021
chaitanya-baraskar
pushed a commit
to chaitanya-baraskar/kanister
that referenced
this pull request
Apr 5, 2021
* added stage to debug gorelease failure * added a newline at the end * removed archive Co-authored-by: Pavan Navarathna <pavan@kasten.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Overview
This PR is to add a test job in kanister to build all tools images before the release. This will let us avoid image build failures when doing a kanister release.
Pull request type
Please check the type of change your PR introduces:
Issues
Test Plan