Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on incorrect file #35

Closed
GitHubRulesOK opened this issue Sep 15, 2017 · 5 comments
Closed

Crash on incorrect file #35

GitHubRulesOK opened this issue Sep 15, 2017 · 5 comments
Labels

Comments

@GitHubRulesOK
Copy link

if a file, folder, sub-folder or zip contains a file with incorrect type (any of these 4 cases)
quickviewer will crash where other apps report incorrect file type

as an example I tried opening a folder that contained sample.pdf that was incorrectly named as sample.png

@kanryu
Copy link
Owner

kanryu commented Sep 15, 2017

Thank you for your report.

This problem will be fixed on next release.

@kanryu kanryu added the bug label Sep 15, 2017
@GitHubRulesOK
Copy link
Author

I am impressed at the speed with which you resolve issues
I was unable to run versions 0.8 due to hardware issues (intel mobile drivers on touchscreen)
However 0.9 is generally stable except for these odd files which took a while to spot the cause as there was no warning. I had to move files around and use a binary chop to find the offending file.

@kanryu
Copy link
Owner

kanryu commented Sep 15, 2017

Improved behavior in 32 bit environment with v0.8.9, and stopped using OpenGL in v0.9.3. With these changes QuickViewer had begun running more consistently on your PC.

A retry was implemented when the image was not able to be read correctly by v0.8.9 correction, but it caused a stack overflow because it is a recursive call.

This issue will not occur in the next release as we set an upper limit for retries.

@kanryu
Copy link
Owner

kanryu commented Sep 20, 2017

@GitHubRulesOK I made it :)

@GitHubRulesOK
Copy link
Author

Bug as reported is corrected does not crash (simply shows blank page)

untitled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants