KAS-4683: Cabinet submissions #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rontend-kaleidos into feature/KAS-4688-indieningen-visualiseren-op-agenda-en-dossier
- add agendaService in new form - use record for submission status - transition to route after saving submission
…ualiseren-op-agenda-en-dossier
…ualiseren-op-agenda-en-dossier
…ualiseren-op-agenda-en-dossier
…indieningen-visualiseren-op-agenda-en-dossier KAS-4688: Indieningen visualiseren op agenda en dossier
KAS-4684: Cabinet submissions - the form
|
Remarks during pair review:
|
2 tasks
|
optimalisations:
|
tdn
approved these changes
Jul 3, 2024
Deze laat ik atm as-is, we moeten anders in die doc view nogal veel data inladen om te achterhalen wat de status van de indiening is. |
KAS-4686: Cabinet submissions (send back)
KAS-4685: Cabinet submissions (the actions)
| return role?.uri === CONSTANTS.MANDATE_ROLES.MINISTER_PRESIDENT; | ||
| }); | ||
| this.submitter = ministerPresident ?? linkedMandatees.slice().at(0); | ||
| this.mandatees = this.submitter ? [this.submitter] : []; |
There was a problem hiding this comment.
there should always be a submitter? this makes it optional
Comment on lines
+46
to
+55
| {{#if this.mayShowMinisterFilter}} | ||
| <div class="au-c-card au-o-box au-o-box--small"> | ||
| <AuLabel>{{t "submitter"}}</AuLabel> | ||
| <Search::MinisterFilter | ||
| @selected={{this.submitters}} | ||
| @onChange={{set this "submitters"}} | ||
| @showPastMinisters={{true}} | ||
| /> | ||
| </div> | ||
| {{/if}} |
There was a problem hiding this comment.
we allow filtering, but we don't show the mandatee in the row (makes sense for cabinet)
Should admins be able to see it? will they even use this view?
Should cabinets be able to see submissions they are linked to but not as submitter?
app/components/documents/batch-details/batch-documents-details-modal.js
Outdated
Show resolved
Hide resolved
…nd-kaleidos into feature/KAS-4683
…rontend-kaleidos into feature/KAS-4683-review
…rontend-kaleidos into feature/KAS-4683-review
…review Feature/kas 4683 review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kanselarij.atlassian.net/browse/KAS-4683
Related PRs/services: