This repository has been archived by the owner on Jan 31, 2019. It is now read-only.
Add --source-dir option to install command. #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows to resolve dependencies from local packages without publishing them. In my case I use multiple packages which all depend on a common package with some common code and functionality. There's no sense in publishing it, because it is highly app-specific. --source-dir option should point to the directory above the local package(s), similar to --target-dir. --source-dir supports multiple directories separated by semicolon ';'. Directories are searched in the order given, left to right.
| }); | ||
|
|
||
| var opt = a.options; | ||
| var pkg = a.positional[0] || '.'; | ||
|
|
||
| if (opt.source_dir) { | ||
| opt.source_dir = opt.source_dir.split(';').reverse(); |
There was a problem hiding this comment.
Any reason to use semicolons here instead of colons (:) just like $PATH in Unix?
There was a problem hiding this comment.
@mandric Just a gesture towards Windows users while not willing to invest any time in Windows-compatible parsing. Personally, I'm OK either way, semicolon, comma or colon.
There was a problem hiding this comment.
Cool, I think colon is the natural fit since like you say we're mostly unix focused right now.
There was a problem hiding this comment.
Your wish is my command. PR updated.
mandric
added a commit
that referenced
this pull request
May 6, 2015
Add --source-dir option to install command.
|
Thanks @kika! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to resolve dependencies from local packages without publishing
them. In my case I use multiple packages which all depend on a
common package with some common code and functionality. There's no sense in
publishing it, because it is highly app-specific.
--source-dir option should point to the directory above the local
package(s), similar to --target-dir.
--source-dir supports multiple directories separated by semicolon ';'.
Directories are searched in the order given, left to right.