Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: break up App.js into it's various component files #22

Closed
profnandaa opened this issue Aug 4, 2017 · 0 comments
Closed

chore: break up App.js into it's various component files #22

profnandaa opened this issue Aug 4, 2017 · 0 comments

Comments

@profnandaa
Copy link
Contributor

profnandaa commented Aug 4, 2017

The App.js file is too long, might be good to break out the various components into the respective component files in src/components directory:

  • /Button.js
  • /PlayerForm.js
  • /BallGrid.js
  • /PlayerList.js
profnandaa added a commit to profnandaa/killer-counter that referenced this issue Aug 5, 2017
- This PR mainly refactors the App.js file into various components.
- I also attempted to reduce the repeating code in miss(), hit(), etc as
  per kanyuga#4
- In addition, I made minor UI fixes on the coloring of the logs (see
  attached screenshot)

closes kanyuga#4, kanyuga#22
profnandaa added a commit to profnandaa/killer-counter that referenced this issue Aug 5, 2017
- This PR mainly refactors the App.js file into various components.
- I also attempted to reduce the repeating code in miss(), hit(), etc as
  per kanyuga#4
- In addition, I made minor UI fixes on the coloring of the logs (see
  attached screenshot)

closes kanyuga#4, kanyuga#22
@kanyuga kanyuga closed this as completed Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants