Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor miss(), hit(), port() and foulBall() to use the same code #4

Closed
kanyuga opened this issue Jul 27, 2017 · 0 comments · Fixed by #27
Closed

Refactor miss(), hit(), port() and foulBall() to use the same code #4

kanyuga opened this issue Jul 27, 2017 · 0 comments · Fixed by #27
Assignees
@kanyuga
Labels
enhancement

Comments

@kanyuga
Copy link
Owner

kanyuga commented Jul 27, 2017

No description provided.

@kanyuga kanyuga self-assigned this Jul 27, 2017
profnandaa added a commit to profnandaa/killer-counter that referenced this issue Aug 5, 2017
@profnandaa
chore: refactor code into component files + unDRY
ca86f60 
- This PR mainly refactors the App.js file into various components.
- I also attempted to reduce the repeating code in miss(), hit(), etc as
  per kanyuga#4
- In addition, I made minor UI fixes on the coloring of the logs (see
  attached screenshot)

closes kanyuga#4, kanyuga#22
@profnandaa profnandaa mentioned this issue Aug 5, 2017
Merged
profnandaa added a commit to profnandaa/killer-counter that referenced this issue Aug 5, 2017
@profnandaa
chore: refactor code into component files + unDRY
d5c57c9 
- This PR mainly refactors the App.js file into various components.
- I also attempted to reduce the repeating code in miss(), hit(), etc as
  per kanyuga#4
- In addition, I made minor UI fixes on the coloring of the logs (see
  attached screenshot)

closes kanyuga#4, kanyuga#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kanyuga kanyuga

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: refactor code into component files + unDRY profnandaa/killer-counter
1 participant
@kanyuga