Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inventory interface for pluggable inventory #1106

Merged
merged 17 commits into from
Jan 26, 2024
Merged

feat: inventory interface for pluggable inventory #1106

merged 17 commits into from
Jan 26, 2024

Conversation

MatteoVoges
Copy link
Contributor

@MatteoVoges MatteoVoges commented Dec 15, 2023 •
edited

Proposed Changes

  • provide new abstract inventory interface
    • each sub inventory needs to implement render_targets()
    • several util / helper methods to access kapitan inventory, instead of accessing multiple dictionary keys
  • implement interface for reclass

@MatteoVoges MatteoVoges self-assigned this Dec 15, 2023
@MatteoVoges MatteoVoges marked this pull request as draft December 15, 2023 10:48
@ademariag ademariag marked this pull request as ready for review January 17, 2024 21:45
@MatteoVoges MatteoVoges added the enhancement enhancement to an existing feature label Jan 26, 2024
@MatteoVoges MatteoVoges mentioned this pull request Jan 26, 2024
Merged
@ademariag ademariag merged commit 8874588 into kapicorp:master Jan 26, 2024
7 checks passed
@MatteoVoges MatteoVoges mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ademariag ademariag ademariag approved these changes

@ramaro ramaro Awaiting requested review from ramaro

Assignees

@MatteoVoges MatteoVoges

Labels
enhancement enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MatteoVoges @ademariag