feat: omegaconf inventory by @MatteoVoges #1173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademariag
force-pushed
the
test/omegaconf
branch
from
f9eaff9
to
0f982f9
Compare
This was referenced Apr 24, 2024
2 tasks
ademariag
added a commit
that referenced
this pull request
May 1, 2024
Incremental changes from OmegaConf work #1173
ademariag
force-pushed
the
test/omegaconf
branch
4 times, most recently
from
249d61b
to
69d5883
Compare
gbamaxw
approved these changes
May 16, 2024
simu
reviewed
May 27, 2024
| @@ -100,10 +105,10 @@ def get_parameters(self, target_names: str | list[str], ignore_class_not_found: | |||
| target = self.get_target(target_names, ignore_class_not_found) | |||
| return target.parameters | |||
|
|
|||
| return {name: target.parameters for name, target in self.get_targets(target_names)} | |||
| return {name: {"parameters": Dict(target.parameters)} for name, target in self.get_targets(target_names)} | |||
There was a problem hiding this comment.
Suggested change
| return {name: {"parameters": Dict(target.parameters)} for name, target in self.get_targets(target_names)} | |
| return {name: {"parameters": dict(target.parameters)} for name, target in self.get_targets(target_names)} |
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def compile_targets( | ||
| inventory_path, search_paths, output_path, parallel, targets, labels, ref_controller, **kwargs | ||
| inventory_path, search_paths, output_path, parallelism, desidered_targets, labels, ref_controller, **kwargs |
There was a problem hiding this comment.
Is desidered_targets a typo of desired_targets?
| @@ -38,6 +38,7 @@ coverage = "^7.5.0" | |||
| docker = "^7.0.0" | |||
| pytest-md = "^0.2.0" | |||
| pytest-emoji = "^0.2.0" | |||
| regex = "^2024.5.10" | |||
There was a problem hiding this comment.
Should be a non-dev dependency, since the omegaconf migration implementation depends on the library
simu
reviewed
May 28, 2024
| shutil.rmtree(compile_path) | ||
| shutil.copytree(temp_compile_path, compile_path) | ||
| logger.debug("Copied %s into %s", temp_compile_path, compile_path) | ||
| logger.info(f"Compiled {len(targets)} targets in (%.2fs)", time.time() - compile_start) |
There was a problem hiding this comment.
I just noticed that this log message looks odd, you probably want either
Suggested change
| logger.info(f"Compiled {len(targets)} targets in (%.2fs)", time.time() - compile_start) | |
| logger.info(f"Compiled {len(targets)} targets (%.2fs)", time.time() - compile_start) |
or
Suggested change
| logger.info(f"Compiled {len(targets)} targets in (%.2fs)", time.time() - compile_start) | |
| logger.info(f"Compiled {len(targets)} targets in %.2fs", time.time() - compile_start) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Instructions
Activate the new inventory
or use the command line flag
--inventory-backend=omegaconfMigrate your inventory to the new setup
Docs and Tests