Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #445: Explicitly create directories for all outputted CompiledFile objects. #446

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Fix issue #445: Explicitly create directories for all outputted CompiledFile objects. #446

merged 1 commit into from
Jan 6, 2020

Conversation

uberspot
Copy link
Contributor

@uberspot uberspot commented Jan 2, 2020

Fixes issue #445

@uberspot uberspot force-pushed the issue_445 branch 2 times, most recently from 7bb1853 to 27f97f2 Compare January 3, 2020 13:00
@uberspot
Copy link
Contributor Author

uberspot commented Jan 6, 2020

I modified this PR to just create the needed dirs in the CompiledFile class for all input types vs creating in jinja2 explicitly.
After investigating more it makes sense that converting to str() can be done explicitly in Kadet anyway so enforcing the conversion isn't necessary.

@uberspot uberspot changed the title Fix issue #445: Explicitly convert plain outputs to str() before writing out to files Fix issue #445: Explicitly create directories for all outputted CompiledFile objects. Jan 6, 2020
@uberspot uberspot merged commit ca3c918 into master Jan 6, 2020
@uberspot uberspot deleted the issue_445 branch January 6, 2020 14:53
@uberspot uberspot mentioned this pull request Jan 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaro ramaro ramaro approved these changes

@adrianchifor adrianchifor adrianchifor approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uberspot @ramaro @adrianchifor @googlebot