-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameter to set kube version for Helm charts rendering #671
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hey @dverbeir thanks for this! I think we could make it more standard with the rest of the helm options if implementing parameters:
compile:
- input_type: helm
output_path: .
input_paths:
- charts/prometheus
kube_version: 1.16
.... That way we can still have a global value passed to it and have targets define their own e.g.: parameters:
my_kube_version: 1.20
kapitan:
compile:
- input_type: helm
output_path: .
input_paths:
- charts/prometheus
kube_version: ${my_kube_version}
.... Also this means that |
c9a8167
to
eeddf3c
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Unfortunately, as |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot What a pain! Could somebody check what's wrong with Google CLA? We set up a corporate CLA 4 days ago and it's still not active... Don't you want contributions??? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hmm, we don't have full control over it. Are you using the exact same email for your git commits as the one you used for the CLA? Afaik that's the main thing that has to match (?). |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I understand it's not under you control, of course. Sorry for letting my frustration out... Exact same email is used. Problem is likely with corporate CLA itself. We contacted cla-submissions@google.com but no response so far... |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just the small nit and we can merge. Don't worry about the CLA issue as you signed it, sometimes the bot is flaky and we can still merge.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
eeddf3c
to
5e8816e
Compare
Some charts generate manifests slightly differently depending on the target Kubernetes version (e.g. targeting different APIs). In order to obtain the appropriate rendered manifests, the Kubernetes version can be set using the `kube_version` compile parameter: parameters: kapitan: compile: - input_type: helm output_path: . input_paths: - charts/prometheus kube_version: "1.16" When not specified, the earlier default of v1.12 is used. This currently only influences Helm chart compilation but the same parameter could be shared with other "compilers". Signed-off-by: David Verbeiren <david.verbeiren@tessares.net>
5e8816e
to
243b297
Compare
@dverbeir as a side effect of moving the repository to kapicorp, the CLA problem should go away :) |
Fixes issue #543
Proposed Changes
Some charts generate manifests slightly differently depending on the target Kubernetes version (e.g. targeting different APIs). In order to obtain the appropriate rendered manifests, the Kubernetes version can be set using the kapitan
kube_version
parameter:kube_version
parameter and passes it to the go libtemplate to be set when rendering the chart.