Feature/new secret backend vault transit #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/add vault transit pr
format the python code
…thub.com/Moep90/kapitan into feature/new_secret_backend_vault_transit
|
tests seams to be fixed with #828 |
This change needs to be merged first: kapicorp/reclass#7 * On the latest version, to render helm template it now uses the helm cli directly. However it seems using helm 3.8.0 (the latest stable), the default behavior if to release name is specify is to populate with the string "release-name", not "RELEASE-NAME" hence all lowercase. There's a simple way to reproduce: ``` helm create test-chart helm template --include-crds --skip-tests ```` And check how {{ .Release.Name }} gets populated when there's none specified. Signed-off-by: Lionel H <me@nullbyte.be>
) The content-type `application/gzip` has been introduced in [RFC 6713][1] as an official type which was intendend to be used instead of various custom content types, such as `application/x-gzip`. It appears that adoption of `application/gzip` is not very high, so its absence from the list of content types which Kapitan tries to unpack hasn't caused issues yet. However, we've now found a dependency (Cilium Enterprise Edition OLM manifests) which is served with `content-type: application/gzip` which results in the following log messages from Kapitan: ``` Dependency https://<REDACTED>/cilium-ee-1.10.4.tar.gz: fetching now Dependency https://<REDACTED>/cilium-ee-1.10.4.tar.gz: successfully fetched Dependency https://<REDACTED>/cilium-ee-1.10.4.tar.gz: Content-Type application/gzip is not supported for unpack. Ignoring save ``` This commit adds `application/gzip` as a supported content type for `.tar.gz` archives in `unpack_downloaded_file()`. [1]: https://datatracker.ietf.org/doc/html/rfc6713
…thub.com/Moep90/kapitan into feature/new_secret_backend_vault_transit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Transit