Substitute ${compiled_target_dir} in env vars for input_type: external
#863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal`
Kapitan already substitutes `${compiled_target_dir}` in the command line
arguments for the command executed for compile objects with
`input_type: external`.
This commit adds logic to also substitue `${compiled_target_dir}` in the
environment variables provided to the external command. This allows
users to specify the compilation target directory in an environment
variable, which can be useful for example to simplify wrapper scripts
which do some work before calling the external tool.
See projectsyn/commodore#646 for an example PR
which implements a wrapper script for `kustomize`. This wrapper script
could benefit greatly from being able to pass the output directory as an
environment variable as it would remove the hard requirement of the
wrapper script that users provide the output path as the first entry in
`args`.
|
Looks good @simu . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kapitan already substitutes
${compiled_target_dir}in the command line arguments for the command executed for compile objects withinput_type: external.This commit adds logic to also substitue
${compiled_target_dir}in the environment variables provided to the external command. This allows users to specify the compilation target directory in an environment variable, which can be useful for example to simplify wrapper scripts which do some work before calling the external tool.See projectsyn/commodore#646 for an example PR which implements a wrapper script for
kustomize. This wrapper script could benefit greatly from being able to pass the output directory as an environment variable as it would remove the hard requirement of the wrapper script that users provide the output path as the first entry inargs.Proposed Changes
${compiled_target_dir}in all environment variables passed in compile objects withinput_type: external.