Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subvar for plain #900

Merged
merged 5 commits into from
Dec 3, 2022
Merged

Fix subvar for plain #900

merged 5 commits into from
Dec 3, 2022

Conversation

ademariag
Copy link
Contributor

@ademariag ademariag commented Nov 30, 2022 •
edited

Fixes issue #899

Proposed Changes

Make subvars fork for

  • plain references
  • references with base64 encoding (it will temporarily decode and re-encode)

@ademariag ademariag marked this pull request as ready for review November 30, 2022 01:38
ramaro
ramaro requested changes Dec 2, 2022
View reviewed changes
docs/references.md Outdated Show resolved Hide resolved
docs/references.md Outdated Show resolved Hide resolved
kapitan/refs/base.py Show resolved Hide resolved
@ademariag ademariag requested a review from ramaro December 3, 2022 10:07
@ademariag ademariag merged commit e656de9 into kapicorp:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaro ramaro Awaiting requested review from ramaro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ademariag @ramaro