fix/non-kapitan-files-on-init-list: refactor populated files listing #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former implementation showed all files in target directory and skipped some of generated files. Now only files generated are shown and formatting has been changed to more tree [1] like - from [2] to [3] Closes kapicorp#306 [1] https://linux.die.net/man/1/tree [2] Populated /tmp/fake with: /tmp/fake /tmp/fake/templates /tmp/fake/templates/docs my_readme.md /tmp/fake/components /tmp/fake/components/other_component __init__.py [3] Populated /tmp/fake with: inventory classes common.yml my_component.yml targets my_target.yml templates scripts my_script.sh docs my_readme.md components my_component my_component.jsonnet other_component __init__.py fixes ae0b444
jkrzemin
force-pushed
the
fix/non-kapitan-files-on-init-list
branch
from
7ac7442
to
5622bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Former implementation showed all files in target directory and skipped some of generated files. Now only files generated are shown and formatting has been changed to more tree [1] like - from [2] to [3]
Closes #306
[1] https://linux.die.net/man/1/tree
[2]
[3]
fixes ae0b444