Topic/duplicate detection #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests don't work at the moment. Needs templating and actual usage of the new method in the Membership model.
Need to add some sort of main header for member_list generic view to be able to distinguish between different views.
Changes enables us to make distinguishable generic views for e.g. duplicates etc.
The return value is rather peculiar and needed more documentation.
Simplifies the implementation, fixes template to include member id and not show duplicate header in duplicate list.
| @@ -6,11 +6,14 @@ | |||
| {% endblock %} | |||
|
|
|||
| {% block content %} | |||
| {% if header %}<h2>{{ header }}</h2>{% endif %} | |||
There was a problem hiding this comment.
Also adds this. Without a way to tell the user they are looking at the duplicates, there's no other indicator. This should be used on other generic membership lists as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements an initial functional version of duplicate membership detection.