Add top-level dummy.go to fix vendoring #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to https://github.com/karalabe/usb/blob/8627268f6b0ac462d2f78166262404901a2d36e0/dummy.go. Without this, `go mod vendor` does not vendor the subdirectories with the C code, but they are required for a successful build.
|
ping @karalabe please merge this so use this repo again instead of my own fork 😄 |
|
@karalabe bump |
|
@karalabe - is there there any other maintainer to ping? Feel free to make me a maintainer if you have too little time - happy to help. |
|
ping @karalabe |
|
@holiman please merge this, this is a very simple PR but without it vendoring does this lib does not work. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
https://github.com/karalabe/usb/blob/8627268f6b0ac462d2f78166262404901a2d36e0/dummy.go.
Without this,
go mod vendordoes not vendor the subdirectories with the C code, but they are required for a successful build.