Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement note skin component #51

Merged
merged 14 commits into from
Apr 5, 2020
Merged

Implement note skin component #51

merged 14 commits into from
Apr 5, 2020

Conversation

andy840119
Copy link
Member

@andy840119 andy840119 commented Apr 4, 2020 •
edited

Implementation of #49, all todos in issue are implemented.
Additional TODO :

  • Create metrics-skin (Normal style)
  • Create special skin (Drawing style)
  • Deal with AccentColour, HitColour, Hitting and Display peoperty. -> need to change into bindable in DefaultBackgroundBodyPiece and DefaultBorderBodyPiece

@andy840119 andy840119 added the enhancement New feature or request label Apr 4, 2020
@andy840119 andy840119 self-assigned this Apr 4, 2020
@andy840119 andy840119 added this to In progress in Legacy skin via automation Apr 4, 2020
@andy840119
Copy link
Member Author

DefaultBackgroundBodyPiece has been implemented with bindable.
Need to make skin for testing and deal with OnDirectionChanged

@andy840119
Copy link
Member Author

Note : combine

NoteBorderHead,
NoteBorderTail,
NoteBorderBody,
NoteBackgroundHead,
NoteBackgroundTail,
NoteBackgroundBody,

into Note because this six skin component should be the same tuple

@andy840119 andy840119 mentioned this pull request Apr 5, 2020
Open
@andy840119
Copy link
Member Author

Most of work are implemented.
Bug wait for another pr.

@andy840119 andy840119 merged commit 1a582b4 into karaoke-dev:master Apr 5, 2020
Legacy skin automation moved this from In progress to Done Apr 5, 2020
@andy840119 andy840119 deleted the _20200404-implement-note-skin-component branch April 5, 2020 09:24
@andy840119 andy840119 mentioned this pull request Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andy840119 andy840119

Labels
enhancement New feature or request
Projects
Legacy skin
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andy840119