Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ppy.osu.Framework from 2023.314.0 to 2023.322.0 #326

Merged
merged 5 commits into from
Mar 25, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 23, 2023

Bumps ppy.osu.Framework from 2023.314.0 to 2023.322.0.

Release notes

Sourced from ppy.osu.Framework's releases.

2023.322.0

Breaking Changes

TexturedShaderDrawNode.TextureShader is made private

This is partially done to force consumers into binding uniform blocks in the newly defined TexturedShaderDrawNode.BindUniformResources method, such that uniform blocks are always bound whenever the corresponding shader is used for drawing in the framework.

For binding/unbinding shaders, use TexturedShaderDrawNode.BindTextureShader/TexturedShaderDrawNode.UnbindTextureShader instead.

What's Changed

Full Changelog: ppy/osu-framework@2023.314.0...2023.322.0

Commits
  • 840aec2 Merge pull request #5681 from frenzibyte/fix-ubo-not-bound
  • 7157211 Merge branch 'master' into fix-ubo-not-bound
  • b1fe5da Merge pull request #5693 from peppy/use-forked-veldrid
  • 60abb36 Merge branch 'master' into fix-ubo-not-bound
  • cb68921 Merge branch 'master' into use-forked-veldrid
  • 4876af7 Merge pull request #5683 from smoogipoo/veldrid-buffer-update-list
  • 02d8ae3 Bump veldrid version with d3d pixel shader version change
  • 13c0214 Move precondition back to setter
  • 148b579 Fix UBOs uploading too often due to off-by-one
  • 35f0bb5 Merge branch 'master' into veldrid-buffer-update-list
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ppy.osu.Framework](https://github.com/ppy/osu-framework) from 2023.314.0 to 2023.322.0.
- [Release notes](https://github.com/ppy/osu-framework/releases)
- [Commits](ppy/osu-framework@2023.314.0...2023.322.0)

---
updated-dependencies:
- dependency-name: ppy.osu.Framework
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Mar 23, 2023
@andy840119
Copy link
Member

Fuck

@andy840119
Copy link
Member

andy840119 commented Mar 24, 2023

Seems not a big issue, happy.

follow the change in the:
ppy/osu-framework@5c2a721

@andy840119 andy840119 force-pushed the dependabot/nuget/ppy.osu.Framework-2023.322.0 branch from 057f301 to 7a2e996 Compare March 24, 2023 05:59
@andy840119
Copy link
Member

todo:
image

  • Need to check why all shaders not working in the osx.

@andy840119
Copy link
Member

andy840119 commented Mar 24, 2023

Got the answer
Some shaders just not works in the metal

image

Only pixel shader works in the metal;_;
Every shader not working in the DirectX

Here's the shader support list, should merge until fix most of the shaders(or at least not make the game crash):
https://karaoke-dev.notion.site/shader-1b0b558a0e2d4fc0b6d2e5925c9d8dba

@andy840119 andy840119 added the API changed Will cause API broken if upgrade the package label Mar 24, 2023
@andy840119 andy840119 self-requested a review as a code owner March 24, 2023 16:45
@pull-request-size pull-request-size bot added size/M and removed size/S labels Mar 24, 2023
@andy840119
Copy link
Member

andy840119 commented Mar 25, 2023

image
Guess let it merge now because most of shader works already 🤔

@andy840119 andy840119 merged commit 3e26640 into master Mar 25, 2023
@andy840119 andy840119 deleted the dependabot/nuget/ppy.osu.Framework-2023.322.0 branch March 25, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API changed Will cause API broken if upgrade the package dependencies Pull requests that update a dependency file size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant