Issue #1834 - Fix for High Severity CVE's in karate-core #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, it builds fine locally. I can see that the Dependency Checker is failing, but I'm not sure why... |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another high-severity CVE was found in
armeriaso I upgraded from1.13.2to1.13.4.I added
dependency-check-mavento the root POM so that dependencies all modules will be checked for CVE's. When doing a build, the check will run during theverifyphase, and the aggregate report will be written totarget/dependency-check-report.html.The dependency check plugin has an option to fail the build if any high-severity CVE's are found. I decided to turn that option off as I believe it will make the build too brittle. This means that a manual review of
target/dependency-check-report.htmlis required to see if any vulnerabilities are present.The report currently shows high-severity CVS's in
karate-gatling,karate-demo, andkarate-robot. While it would be nice to address those in the future, I believe we can leave them for now since those modules are not shaded.