Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1834 - Publish Non-Shaded JAR For karate-core #1916

Merged
merged 1 commit into from Mar 3, 2022

Conversation

packleader
Copy link
Contributor

Description

Publishing a non-shaded JAR will enable clients to upgrade and/or exclude dependencies based on their specific use cases. For example, if the version of Netty used by Karate is discovered to have a severe security flaw, our users can specify a newer version of Netty in their pom to override the dependency inherited from Karate. This is currently not possible with the shaded JAR.

Both JARs will be published to Maven Central under com/intuit/karate/karate-core/1.2.0, and the filenames will be karate-core-1.2.0.jar and karate-core-1.2.0-all.jar.

Clients will reference the non-shaded JAR using

<dependency>
    <groupId>com.intuit.karate</groupId>
    <artifactId>karate-core</artifactId>
    <version>1.2.0</version>
</dependency>

And they can reference the shaded JAR with

<dependency>
    <groupId>com.intuit.karate</groupId>
    <artifactId>karate-core</artifactId>
    <version>1.2.0</version>
    <classifier>all</classifier>
</dependency>

@@ -192,6 +192,8 @@
<goal>shade</goal>
</goals>
<configuration>
<shadedArtifactAttached>true</shadedArtifactAttached>
<shadedClassifierName>all</shadedClassifierName>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if y'all want to use a different name for the shaded JAR...

@packleader
Copy link
Contributor Author

@ptrthomas Any thoughts on this one?

@ptrthomas ptrthomas merged commit 8bbbe11 into karatelabs:develop Mar 3, 2022
@ptrthomas
Copy link
Member

@packleader 1.2.0.RC5 has been released. please let me know at the earliest if it works. it would be great if you can validate the release notes here: https://github.com/karatelabs/karate/wiki/1.2.0-Upgrade-Guide

@packleader
Copy link
Contributor Author

@ptrthomas I've tested out 1.2.0.RC25, and it looks great! The upgrade guide looks good, too. I've been able to validate that all the issues I've submitted have been resolved. I'm looking forward to the final release of 1.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants