Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/2114 reusing active connections #2123

Conversation

mj11pyqe
Copy link

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

  • Relevant Issues : Reusing active connection #2114
  • Relevant PRs : (optional)
  • Type of change :
    • New feature
    • Bug fix for existing feature
    • Code quality improvement
    • Addition or Improvement of tests
    • Addition or Improvement of documentation

@mj11pyqe mj11pyqe changed the base branch from master to develop September 23, 2022 09:48
@ptrthomas
Copy link
Member

@mj11pyqe the build failed and I tried to re-run it once. I did not study the logs yet - but please see if you missed something. are the tests running locally for you ? https://github.com/karatelabs/karate/actions/runs/3111828909

@mj11pyqe
Copy link
Author

@ptrthomas I am getting same errors on local branch and on master

@ptrthomas
Copy link
Member

just to be clear, this PR cannot be merged until we are sure that all tests pass

@ptrthomas
Copy link
Member

closing because of inactivity

@ptrthomas ptrthomas closed this Oct 29, 2022
@mj11pyqe
Copy link
Author

mj11pyqe commented Dec 11, 2022

I updated the fork in a new pull requets #2213

@mj11pyqe mj11pyqe mentioned this pull request Dec 11, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants