Tcp connection reusage

[mj11pyqe]

Description

Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the develop branch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.

• Relevant Issues : Reusing active connection #2114
• Relevant PRs : Feature/2114 reusing active connections #2123
• Type of change :
  • New feature
  • Bug fix for existing feature
  • Code quality improvement
  • Addition or Improvement of tests
  • Addition or Improvement of documentation

[ptrthomas]

@mj11pyqe sorry, can you please resolve conflicts. maybe you have not pulled latest version

[ptrthomas]

also can you please make the diff as small as possible (else it is too hard to review)

if we can't merge this, please note that using your own http client, is easy in karate, there is an API to swap it. so you can do this for some time and report back how it works. else I am not confident making this change without more testing

refer the docs here: https://github.com/karatelabs/karate/tree/master/karate-mock-servlet#switching-the-http-client

[mj11pyqe]

My bad, I requested to merge wrong branch, it is old indeed, will open new pull request instead

if we can't merge this, please note that using your own http client, is easy in karate, there is an API to swap it. so you can do this for some time and report back how it works. else I am not confident making this change without more testing

Thank you so much for the hint, was not aware of this

[mj11pyqe]

will not create a pull request, there is always an error that I could not fix.

For reference: using own httpClient as mentioned in https://github.com/karatelabs/karate/tree/master/karate-mock-servlet#switching-the-http-client works pretty well.

This is what I did.

public interface ReusableHttpClientFactory extends HttpClientFactory {
  HttpClientFactory CUSTOM = ReusableHttpClient::new;
}

public class ReusableHttpClient implements HttpClient {
//copied karate implementation and then adapted it.
}

public class AllTestsRunner {

  @Test
  void testAll() {
    Results results =
        Runner.path("classpath:com/x/y/z")
            .clientFactory(ReusableHttpClientFactory.CUSTOM)
            .parallel(1);
  }
}