Connect api #4
Connect api #4
Conversation
karayamanemre
commented
Nov 8, 2022
karayamanemre
commented
- Added Redux thunk.
- Created a new app in the Bookstore API.
- Functions created for adding&removing.
- Used fetch for API calls.
There was a problem hiding this comment.
Hi Emre,
You did extremely great on this project! 👏 👏
There are however a few issues that you still need to work on to go to the next project, but you are almost there! 🚦 🚦 🚦
Highlights 👍
- Nice job for properly using axios for API calls
Required Changes ♻️
Kindly check the comments under the review.
You can also consider:
- I think you should change the header title Authors to Author in your ReadMe, as this project is worked on by sole contributor.
Implementing the above change(s) will make your ReadMe/ repository stand out even better 😉
Cheers and Happy coding!👏 💻 🍷
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -1,12 +1,13 @@ | |||
| import { createStore, combineReducers } from 'redux'; | |||
| import { createStore, combineReducers, applyMiddleware } from 'redux'; | |||
| import thunk from 'redux-thunk'; | |||
| import booksReducer from './books/books'; | |||
| import categoriesReducer from './categories/categories'; | |||
|
|
|||
There was a problem hiding this comment.
- This activity requires that you use
createAsyncThunkfor creating thunk action creators, which should be similar to this example:
import { createAsyncThunk, createSlice } from '@reduxjs/toolkit';
import axios from 'axios';
export const getBooks = createAsyncThunk(
'books/getBooks',
async () => {
const response = await axios.get(
'https://us-central1-bookstore-api-e63c8.cloudfunctions.net/bookstoreApi/',
);
return response.data;
},
); 
There was a problem hiding this comment.
- [REQUIRED] Good job updating your readme But as mentioned by the previous reviewer you should use fetch or axios with createAsyncThunk for making API calls as required for this project. Please fix it 😄
There was a problem hiding this comment.
Sorry, I don't get this part my app is working correctly according to requirements. What is that I'm missing?
There was a problem hiding this comment.
Hi @karayamanemre ,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
- Good commits history ✔️
- No linters errors ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me (@codecaiine) in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Hi @karayamanemre,
APPROVED 🟢
Highlights
✔️ Descriptive PR
✔️ Passing linters
✔️ Good branch name
Great implementation of all the requirements in this milestone. 👏
You have done an amazing job 👍
Your project is complete! There is nothing else to say other than... it's time to merge it. 
Congratulations! 🎉
CHEERS AND HAPPY CODING!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
