Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to load colors from XResources #113

Open
karlch opened this issue Sep 30, 2019 · 0 comments
Open

Option to load colors from XResources #113

karlch opened this issue Sep 30, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted

Comments

@karlch
Copy link
Owner

karlch commented Sep 30, 2019

As mentioned in #62 loading colors from xresources is a great feature.

After merging #123, the vimiv part of the implementation should be straightforward. It requires:

  1. A function to replace an X resource string with the correct value similar to getenv in config.external_configparser.
  2. Adding this function with a corresponding prefix to ExternalInterpolation.CONVERTERS.

In case another dependency is used, it should stay optional following the

try:
    import xresourcelib
except ImportError:
    xresourcelib = None

pattern and checking for if xresourcelib is not None in the required places.

@karlch karlch added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2019
@karlch karlch mentioned this issue Sep 30, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted
Projects
None yet
Development

No branches or pull requests

1 participant