Stop watching SIGTERM before starting process #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1koo
force-pushed
the
fix_closing_birth_channel
branch
from
b29740b
to
e34477f
Compare
n1koo
force-pushed
the
fix_closing_birth_channel
branch
from
e34477f
to
e2d2136
Compare
alessiovolpe
referenced
this pull request
in Musixmatchdev/kubexit
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a problem where during start we never close the parent channel that watches for
SIGTERMresulting in double signal watchers that collide with each other.parentCancel()is safe to call (no double cancel) when coming out of pod watching due to the fact we now bail out withos.Exit(0on line219rather than starting the app and skipping watches.