Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KarlsenHashV2-Fishhash Karlsen Node & CPU miner for Testnet-1 #29

Merged
merged 11 commits into from
Jan 21, 2024

Conversation

wam-rd
Copy link
Collaborator

@wam-rd wam-rd commented Jan 21, 2024

First implementation of fishhash algo on the karlsend & karlsenminer.
This first iteration is as close as possible to fishhash whitepaper (same seed, same prebuilt dataset epoch 488, etc)
The kheavyhash kernel is still present in the codesource for future algo switch but not used yet
It means this version is KarlsenHashV2 compatible only

todo :

  • better comments on codesource
  • test suite for fishhash

algo iteration name : fishhash-kls-0.0.1

Copy link

@okilisan okilisan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments
Everything ok for me.

domain/consensus/utils/pow/fishhash.go Show resolved Hide resolved
domain/consensus/utils/pow/heavyhash_test.go Show resolved Hide resolved
app/app.go Show resolved Hide resolved
domain/consensus/utils/pow/fishhash.go Show resolved Hide resolved
domain/consensus/utils/pow/heavyhash_test.go Show resolved Hide resolved
domain/dagconfig/params.go Show resolved Hide resolved
version/version.go Show resolved Hide resolved
@lemois-1337
Copy link
Collaborator

Looks good, merged into testnet-1 branch.

@lemois-1337 lemois-1337 merged commit b9c6d1a into karlsen-network:2024_testnet_1_fishhash Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants