forked from kaspanet/kaspad
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KarlsenHashV2-Fishhash Karlsen Node & CPU miner for Testnet-1 #29
Merged
lemois-1337
merged 11 commits into
karlsen-network:2024_testnet_1_fishhash
from
wam-rd:fishhash
Jan 21, 2024
Merged
KarlsenHashV2-Fishhash Karlsen Node & CPU miner for Testnet-1 #29
lemois-1337
merged 11 commits into
karlsen-network:2024_testnet_1_fishhash
from
wam-rd:fishhash
Jan 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okilisan
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments
Everything ok for me.
lemois-1337
reviewed
Jan 21, 2024
lemois-1337
approved these changes
Jan 21, 2024
Looks good, merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementation of fishhash algo on the karlsend & karlsenminer.
This first iteration is as close as possible to fishhash whitepaper (same seed, same prebuilt dataset epoch 488, etc)
The kheavyhash kernel is still present in the codesource for future algo switch but not used yet
It means this version is KarlsenHashV2 compatible only
todo :
algo iteration name : fishhash-kls-0.0.1