Support google-chrome-stable, chromium-browser, and chromium #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzo
added a commit
that referenced
this pull request
Apr 16, 2015
Support google-chrome-stable, chromium-browser, and chromium
Krinkle
added a commit
to wikimedia/unicodejs
that referenced
this pull request
Apr 29, 2015
* Add grunt-cli so that users don't need grunt-cli pre-installed globally. * karma-coverage@0.3.0 Fixes karma-runner/karma-coverage#24 * karma-chrome-launcher@0.1.8 Fixes karma-runner/karma-chrome-launcher#41. This will allow our Jenkins setup to rid the CHROME_BIN hack, after all projects have updated. * grunt-jscs@1.8.0: Addresses T90816. Change-Id: I49eb93e590e475536bbaaa30b83ea888390190d2
wmfgerrit
pushed a commit
to wikimedia/integration-zuul-config
that referenced
this pull request
Mar 8, 2016
CHROME_BIN is no more needed since karma-chrome-launcher v0.1.8 and Timo patch: karma-runner/karma-chrome-launcher#41 By setting DISPLAY directly from Zuul, we remove some logic from the slave-scripts. A baby step toward phasing them out. Bug: T128090 Signed-off-by: Antoine Musso <hashar@free.fr> Change-Id: If026b795d66c3d3c0f3d35b74bfe54d49dd93e69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #17.