Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console only output still makes files. #24

Closed
eighteyes opened this issue Oct 19, 2013 · 5 comments · Fixed by #86
Closed

Console only output still makes files. #24

eighteyes opened this issue Oct 19, 2013 · 5 comments · Fixed by #86

Comments

@eighteyes
Copy link

Even with no dir on coverageReporter, there are still files / directories made.

@SimplGy
Copy link

SimplGy commented Feb 4, 2014

Ya, true story. Tried file:null, file:'', and dir:null

@Krinkle
Copy link
Contributor

Krinkle commented Jul 19, 2014

👍

When running with Grunt, the following caused a coverage/ directory to be created in the root of the repository:

                coverageReporter: { reporters: [
                    {
                        type: 'html',
                        dir: 'dist/coverage/'
                    },
                    {
                        type: 'text-summary'
                    }
                ] },

Which is a bit odd as it leaves the tree with:

- coverage !untracked
  - PhantomJS 1.9.7 (Mac OS X)/
    (empty)
- dist
  - coverage
    - PhantomJS 1.9.7 (Mac OS X)/
      - index.html
      - ..

@gabegorelick
Copy link

Now that there's a PR that fixes this, can we expect a fix?

@aj-dev
Copy link

aj-dev commented Sep 29, 2014

Are there any updates on this issue?

@grabbou
Copy link

grabbou commented Nov 2, 2014

Yep, same here.
I have two folders:

client
| - test
server
karma.conf.js

Coverage creates two folders, on under root directory (always empty) and the second one inside client folder - I've been looking for it for few minutes and thanks to @Krinkle comment I've discovered that it's under subdirectory as well.

Krinkle added a commit to wikimedia/oojs-core that referenced this issue Apr 16, 2015
* karma-coverage@0.3.0: Includes fix for karma-runner/karma-coverage#24.
  We can remove the workaround config in text-console that was
  there to prevent an unwanted directory from being created.

* karma-chrome-launcher@0.1.8: Includes support for "chromium-browser"
  (in addition to "chromium") so we can eventually remove the hack
  in Jenkins that exports CHROME_BIN=chromium-browser.

Change-Id: Ie360a93b2324d4a0736bbd86939e4c965574ae0b
Krinkle added a commit to wikimedia/unicodejs that referenced this issue Apr 29, 2015
* Add grunt-cli so that users don't need grunt-cli pre-installed globally.

* karma-coverage@0.3.0
  Fixes karma-runner/karma-coverage#24

* karma-chrome-launcher@0.1.8
  Fixes karma-runner/karma-chrome-launcher#41.
  This will allow our Jenkins setup to rid the CHROME_BIN hack, after all
  projects have updated.

* grunt-jscs@1.8.0: Addresses T90816.

Change-Id: I49eb93e590e475536bbaaa30b83ea888390190d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants