use qunit css instead of inline styles #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
requested changes
Jun 6, 2018
package.json
Outdated
| @@ -5,7 +5,7 @@ | |||
| "main": "lib/index.js", | |||
| "scripts": { | |||
| "lint": "grunt eslint", | |||
| "test": "grunt", | |||
| "test": "grunt && mocha test/lib", | |||
There was a problem hiding this comment.
mocha test/lib is already launched by travis, by doing that you launched it twice
|
@Johann-S, but it doesn't run locally unless I run it explicitly - is that expected? Maybe just use |
|
yep that's not convenient we should do that in a npm script to enable folks to use it 🤔 |
|
Good job @asapach 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #109 this is what it would look like if we got rid of inline styles for
qunit-fixtureand used QUnit CSS instead.