Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump karma and dependencies #48041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump karma and dependencies #48041

wants to merge 1 commit into from

Conversation

zzak
Copy link
Member

@zzak zzak commented Apr 24, 2023

My only question is how does the global yarn.lock file get updated?
https://github.com/rails/rails/blob/main/yarn.lock

There is also a problem with karma-sauce-launcher with 4.0.0 that we will want to avoid specifically:
karma-runner/karma-sauce-launcher#190

@guilleiguaran
Copy link
Member

My only question is how does the global yarn.lock file get updated?

Maybe this?

yarn upgrade karma-sauce-launcher@^4.3.6

@zzak
Copy link
Member Author

zzak commented Apr 24, 2023

yarn upgrade karma-sauce-launcher@^4.3.6

This adds a huge diff to the root yarn.lock file, and adds karma-sauce-launcher to the root package.json dependencies.

From the CI config, it seems we run yarn install from the root, and npm install from the actionview directory.

There doesn't seem to be any documentation for how this file is maintained that I could find. 🤔

@skipkayhil
Copy link
Member

I think a yarn install would update the lockfile?

and npm install from the actionview directory.

This definitely seems wrong, we should probably be using yarn everywhere.

@zzak
Copy link
Member Author

zzak commented Apr 27, 2023

and npm install from the actionview directory.

This definitely seems wrong, we should probably be using yarn everywhere.

We do except actionview (at least in CI) for whatever reason:
https://github.com/rails/buildkite-config/blob/cde08283a7f570c1b0185eb626f835e393350801/Dockerfile#L115-L124

I think a yarn install would update the lockfile?

Will update the PR with yarn install run from the root 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants