Skip to content

Commit

Permalink
chore(test): fix client tests in older IE versions (#3547)
Browse files Browse the repository at this point in the history
By locking sinon to the older version. The problem was that new version of sinon brought newer versions of several dependencies, which use ES2016 Map, which is not available in the older IE versions. The solution is fragile as we can't reliably lock transitive dependencies, but should do for now to make master green.

As a proper solution we should consider cutting a new major release, where we would drop support for ancient browsers and more clearly document which browsers karma aims to support.
  • Loading branch information
devoto13 committed Aug 31, 2020
1 parent 7a94d33 commit f34b38f
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 37 deletions.
50 changes: 14 additions & 36 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -463,7 +463,7 @@
"proxyquire": "^2.1.3",
"puppeteer": "^1.20.0",
"semantic-release": "^15.14.0",
"sinon": "^7.5.0",
"sinon": "7.3.2",
"sinon-chai": "^3.5.0",
"supertest": "^4.0.2",
"timer-shim": "^0.3.0",
Expand Down

0 comments on commit f34b38f

Please sign in to comment.