We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Related to #1097, the URL_REGEXP in karma/lib/reporter.js fails for karma-browserify. Karma-browserify spits out urls like this:
URL_REGEXP
karma/lib/reporter.js
absolute/var/folders/vl/_5jh_5_n3njb7rfcg5tr87p80000gn/T/2316ae91e848b763869f68a80a8e5489.browserify?745c3db05ccd6d7437dca35f2a7b84cdfb23abf1:17133:22
Whereas the expression,
var URL_REGEXP = new RegExp('http:\\/\\/[^\\/]*\\/' + '(base|absolute)' + // prefix '((?:[A-z]\\:)?[^\\?\\s\\:]*)' + // path '(\\?\\w*)?' + // sha '(\\:(\\d+))?' + // line '(\\:(\\d+))?' + // column '', 'g')
clearly does not match the output. A simple fix that I have tested is to remove the protocol, like this:
var URL_REGEXP = new RegExp('\\/' + '(base|absolute)' + // prefix '((?:[A-z]\\:)?[^\\?\\s\\:]*)' + // path '(\\?\\w*)?' + // sha '(\\:(\\d+))?' + // line '(\\:(\\d+))?' + // column '', 'g')
I will cross-post an issue with karma-browserify, as the fix may be preferable on their end.
The text was updated successfully, but these errors were encountered:
http://
Here's a minimum working example:
https://gist.github.com/brianmhunt/e9b54d35af5c6537e3c8
Sorry, something went wrong.
Thanks @brianmhunt for the investigation, I'm happy with your suggested fix. Are you up for a PR?
Ensure errors use the source map
b71ad8b
Closes karma-runner#1495
0407a22
Awesome, thanks @dignifiedquire
Successfully merging a pull request may close this issue.
Related to #1097, the
URL_REGEXP
inkarma/lib/reporter.js
fails for karma-browserify. Karma-browserify spits out urls like this:Whereas the expression,
clearly does not match the output. A simple fix that I have tested is to remove the protocol, like this:
I will cross-post an issue with karma-browserify, as the fix may be preferable on their end.
The text was updated successfully, but these errors were encountered: