New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make visible definition (args) of custom(logger|reporter) to it's base class and decorators #1738
Labels
Comments
comdiv
added a commit
to comdiv/karma
that referenced
this issue
Dec 2, 2015
Allows custom(reporter|launcher)'a args to be accessible from Launcher(Reporter)Base Closes karma-runner#1738
comdiv
added a commit
to comdiv/karma
that referenced
this issue
Dec 2, 2015
Allows custom(reporter|launcher)'a args to be accessible from Launcher(Reporter)Base Closes karma-runner#1738
comdiv
added a commit
to comdiv/karma
that referenced
this issue
Dec 2, 2015
Allows custom(reporter|launcher)'a args to be accessible from Launcher(Reporter)Base Closes karma-runner#1738
comdiv
added a commit
to comdiv/karma
that referenced
this issue
Dec 2, 2015
Allows custom(reporter|launcher)'a args to be accessible from Launcher(Reporter)Base Closes karma-runner#1738
comdiv
added a commit
to comdiv/karma
that referenced
this issue
Dec 2, 2015
Allows custom(reporter|launcher)'a args to be accessible from Launcher(Reporter)Base Closes karma-runner#1738
comdiv
added a commit
to comdiv/karma
that referenced
this issue
Dec 2, 2015
Allows custom(reporter|launcher)'a args to be accessible from Launcher(Reporter)Base Closes karma-runner#1738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When i start to implement #1737 - i have found that where is not simple way to make such behavior at BaseLauncher or launcherDecorator level - because they are instanced and used without access to
args
of customLauncher (reporter) through injector, while it waslocal
for custom factory.While custom factory is not requied to do something with
args
they are used just in .ctor method on customer way and then is lost (so it is in karma-firefox-launcher for example).So while #1737 is based on idea that 'binpath' will be accessible from BaseLauncher - it must be way to supply source definition (from config) to it.
It's not only about #1737 - it can be different scenarios when we could want to modify/setup core launcher/reporter behavior from config for any customLauncher(reporter) of any base type.
Have implement it in my fork and will prepare update soon. I have not found way to do it with injector and made it strait by defining instance variable with special name at factory level and supply null-safe accessor to it at BaseLauncher(Reporter) level.
The text was updated successfully, but these errors were encountered: