Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle absolute paths on Windows #251

Open
vojtajina opened this issue Dec 19, 2012 · 10 comments
Open

Handle absolute paths on Windows #251

vojtajina opened this issue Dec 19, 2012 · 10 comments

Comments

@vojtajina
Copy link
Contributor

Based on https://github.com/vojtajina/testacular/issues/249

Let's add another if (windows) and handle the absolute paths on windows to something like /absolute/c/path/to/file.js.

@dignifiedquire
Copy link
Member

Do you mean we simply transform something like C:\Programs\Node to /absolute/C/Programs/Node?

@dignifiedquire
Copy link
Member

I think I've found two modules that might be a good solution for resolving all the path issues cross platform.

They are very new but I think they exactly adress the problems we are facing.

@vojtajina
Copy link
Contributor Author

In order to not expose full paths (when possible), Testacular serves all files from basePath as /base/....

All other files are served as /absolute/usr/local/..., which on windows results in /absoluteC:\whatever so we just need to deal with it.

@willprice
Copy link

Is there any workaround for this at the moment as it is preventing me from using Karma as my test runner.

@dignifiedquire dignifiedquire added this to the v1.0 milestone Jul 16, 2015
@dignifiedquire
Copy link
Member

Not that I know about sorry, but I hope to get this fixed soon

@willprice
Copy link

That's good to know, thanks for getting back to me so quickly.

@dignifiedquire dignifiedquire modified the milestone: v1.0 Jan 8, 2016
@n370
Copy link

n370 commented May 28, 2017

Hey @dignifiedquire is there something I can do to help getting this corrected for the next release?

@igomezal
Copy link

With karma v4.0.0 gives me the following error: [web-server]: 404: /absoluteC:/Users/..., I am not sure but is it possible that it is not creating the correct route?

Is there any workaround to make it work on windows?

@johnjbarton
Copy link
Contributor

Every commit is tested on Windows, eg https://ci.appveyor.com/project/dignifiedquire/karma/builds/22080177/job/oq6xvy45jl3fg0dx

So whatever problem you are having, it is not fundamental to karma.

@igomezal
Copy link

Yeah, you are right, it could be a problem with the latest version of karma-webpack (alpha) because the previous one seems to work fine. (codymikol/karma-webpack#396)

I would keep looking for the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants