require() in config file does not hangle relative paths

[vojtajina]

Only abs paths work: require(__dirname + '/something.js');, because the require behaves as if it was run within config.js file, so you can load Testacular's source modules ;-)

[vojtajina]

I'm really leaning towards changing the config file to be required as any other source file.

It will make the config file a bit more verbose, but will solve all these issues.

The syntax might be something like:

module.exports = function(config) {
  config.files = [...];
  config.reporters = ['dots];
};

Or

module.exports = {
  browsers: ['Safari', 'Chrome'],
  reporters: ['dots']
};

[dignifiedquire]

👍 for the first run. This would make it easy for all people familiar withgrunt config.

[dignifiedquire]

I've written up an alternative suggestion that is a much cleaner solution to this in my opinion. You can see it in this gist. In short the idea is to use YAML as config file format with some extras on top to keep all necessary options available.

[vojtajina]

I feel very strongly about having the config file in JavaScript. It's powerful.

You can require other files, you can easily read env variables... and once we refactor for plugins, it allows for inlining plugins and many many other stuff.

Everyone who uses Testacular is familiar with JS.

[dignifiedquire]

I see your points. Alright if JS then im all for something along the lines of

module.exports = function(testacular) {
  testacular.configure({
    browsers: ['Safari', 'Chrome'],
    reporters: ['dots']
  });
  // Maybe some plugin loading commands here on the testacular object
};

[vojtajina]

@pavelgj Let's do this instead...

• the config file is required as any other js file (therefore require and everything works just as expected)
• config object is just a hash object passed to the user default config first (~/.karma.conf.js) then to project specific
• we keep the whole object (you can add custom properties)

[pavelgj]

@vojtajina SGTM. +1 on doing it the right way. Did you already start working on it or do you want me to give it a shot?

[vojtajina]

I have it pretty much done. I just need to decide which API is the best. I
will discuss it with Misko, feel free to stop by tomorrow...

On Wed, Apr 3, 2013 at 8:53 PM, Pavel Jbanov notifications@github.comwrote:

@vojtajina https://github.com/vojtajina SGTM. +1 on doing it the right
way. Did you already start working on it or do you want me to give it a
shot?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/304#issuecomment-15878703
.

[vojtajina]

module.exports = function(karma) {
  karma.configure({
    basePath: '../',
    files: ['src/**/*.js']
  });

  // custom DSL
  karma.definePreprocessor('coffee_bare', {
    name: 'coffee',
    args: {'bare': false}
  });

  karma.defineLauncher('chrome', {
    name: 'Chrome',
    args: ['--flag']
  });
};