Given up on semver?

[alasdairhurst]

Looking at all the 2.x releases i don't see any attempt to follow semver, with breaking changes and features dotted around in each patch version. Are we expected to just rely on package-lock to stop CI picking up breaking changes unexpectedly now?

[johnjbarton]

There are no changes to the API in 2.x. If you have a specific bug, please provide actual information.

[alasdairhurst]

The changelog says otherwise On 7 Aug 2018 16:05, johnjbarton <notifications@github.com> wrote: There are no changes to the API in 2.x. If you have a specific bug, please provide actual information. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3105 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AIDP0iyiq0-GvCIa2Aq14_0fJGyA9esBks5uOayigaJpZM4VyDZZ>.

[leoselig]

@johnjbarton I feel like @alasdairhurst got a point there. E.g. v2.0.3 explicitly lists "BREAKING CHANGES".
On the other hand, the new v3.0.0-release only contains "Bug Fixes".

karma can indeed only be used reliably at the moment if locked to a specific patch version. This is not meant to be condescending. It just begs the question whether SemVer is something the team is not willing to commit to.

[johnjbarton]

You are welcome to review changes as they occur and suggest improvements.

What breaking changes occurred in 2.0.3?

v3 dropped node 4, a breaking change.

[leoselig]

@johnjbarton

What breaking changes occurred in 2.0.3?

I'm afraid I already clearly stated that in my comment:

v3 dropped node 4, a breaking change.

This is correct. However, as visible from the link I put into my comment, I was referring to the releases page: https://github.com/karma-runner/karma/releases/tag/v3.0.0
There it does not include that change. Apparently, the breaking change got documented later in
commit ab9333f specifically in the CHANGELOG.md 10 hours ago. I usually refer to the releases page first and only if those are unmaintained do I consult any changelog files.

[johnjbarton]

v2.0.3 had no breaking change; the docs were wrong due to an old error, and they were corrected.

v3.0.0 had breaking changes; the docs omitted these, turns out 'chore' commits are omitted from the change log. The error has also been corrected.

Next time please consider sending a PR to fix docs.

[Florian-R]

@johnjbarton Any chance to add this breaking change in https://github.com/karma-runner/karma/releases ?

Missed that when scanning the changelog through this page.

[johnjbarton]

Ugh, 2 changelogs? We should delete one.

I updated the second one as well, thanks.