fix(preprocessor): Lookup patterns once invoked #1341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't lookup the list of patterns of files to preprocess until the preprocessor is called. This because patterns might be added after the preprocessor is created, and those will be missed if the patterns are looked up too early. Closes karma-runner#1340
|
@andersekdahl Thanks
Can you explain when such a case occurs |
|
It's an issue when you're creating a plugin and you want to add a file that you also want to preprocess. That is, in your framework factory function, you add an entry to config.files and add an entry to config.preprocessors for that file. Because of this bug, the preprocessor is never run for the added file. So this PR is perhaps not the best way forward for allowing this, but it's a very small, low-impact change. I'd much rather see some sort of stream-pipeline which you could push files through at any time, but I'm not familiar enough with the code base to propose such a change. |
|
related issues |
|
LGTM |
dignifiedquire
added a commit
that referenced
this pull request
Jun 4, 2015
…lookup fix(preprocessor): Lookup patterns once invoked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't lookup the list of patterns of files to preprocess until the
preprocessor is called. This because patterns might be added after the
preprocessor is created, and those will be missed if the patterns are
looked up too early.
Closes #1340