Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Upgrade connect 3. #1413

Closed
wants to merge 2 commits into from

Conversation

dignifiedquire
Copy link
Member

This means dropping support for node 0.8.

This is pretty much working but the tests are broken as the outdated mocks library is not handling the req.resume and req.pause methods properly.

Found a good replacement https://github.com/WhoopInc/supertest-as-promised and refactored all the failing tests. We should plan to move all the other tests for middleware to it as well, as it is much more reliable.


Ref #1410

@dignifiedquire dignifiedquire self-assigned this May 17, 2015
@dignifiedquire dignifiedquire added this to the v1.0 milestone May 17, 2015
@dignifiedquire dignifiedquire mentioned this pull request May 17, 2015
11 tasks
@dignifiedquire dignifiedquire changed the title [WIP] chore(deps): Upgrade connect 3. fix(deps): Upgrade connect 3. May 20, 2015
@dignifiedquire dignifiedquire removed their assignment May 20, 2015
@dignifiedquire dignifiedquire force-pushed the connect-3 branch 2 times, most recently from e710bd6 to 762c3b5 Compare May 21, 2015 08:16
@dignifiedquire
Copy link
Member Author

@maksimr could you review this please?

@maksimr
Copy link
Contributor

maksimr commented May 25, 2015

LGTM

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dignifiedquire
Copy link
Member Author

Merged into canary as d585032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants