Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(static): Support media queries #1543

Merged
merged 1 commit into from Aug 6, 2015

Conversation

unional
Copy link
Contributor

@unional unional commented Aug 5, 2015

Add meta tags in static html files

@GitCop
Copy link

GitCop commented Aug 5, 2015

There were the following issues with your Pull Request

  • Commit: 12fb2a0
    • Commits must be in the following format: %{type}(%{scope}): %{description}

Guidelines are available at http://karma-runner.github.io/0.13/dev/git-commit-msg.html


This message was auto-generated by https://gitcop.com

@unional
Copy link
Contributor Author

unional commented Aug 5, 2015

Sorry about the last two PR, apparently I can't spell.

But the message still has problem?

@dignifiedquire
Copy link
Member

Yeah, the issue is that it expects a scope, so something like feat(client): Support media queries.

By the way you don't have to make new PRs if you just want to change the commit message, take a look at this https://help.github.com/articles/changing-a-commit-message/

Add meta tags in static html files
@unional unional changed the title feat: Support media queries feat(static): Support media queries Aug 5, 2015
@unional
Copy link
Contributor Author

unional commented Aug 5, 2015

Thanks. I have updated the commit message. Never tried to do a force push on amend, learned new stuff. :)
I use static as the scope. Would that be ok? According to the doc, scope should be optional thou.

@dignifiedquire
Copy link
Member

Yes in general it's optional, but the bot is not that intelligent ;)
Looks fine now thanks

@dignifiedquire
Copy link
Member

I will merge this into the canary branch tomorrow, and release it as such, as this could be breaking tests if people rely on it not being present.

@dignifiedquire dignifiedquire self-assigned this Aug 5, 2015
@unional
Copy link
Contributor Author

unional commented Aug 5, 2015

What is the purpose / target of the canary branch?

@dignifiedquire
Copy link
Member

It's a preview of the next release which allows for breaking changes. It'll have a version like 0.14.0-rc.0. And ar some point it will be released as new stable release, i.e 0.14.0

dignifiedquire added a commit that referenced this pull request Aug 6, 2015
feat(static): Support media queries
@dignifiedquire dignifiedquire merged commit c295804 into karma-runner:master Aug 6, 2015
@dignifiedquire
Copy link
Member

I changed my mind, let's try this in stable. Published as 0.13.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants